fix: reduce asynchronous stuff to resolve flickering #1951
Merged
+87
−74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this commit, we introduce a slightly smarter approach to handling custom module registration and executing the `beforeRender` function. The current issue is that the `quill-editor-toolbar` may be projected before the editor is rendered due to the `Promise.all` in `mergeMap`. This is noticeable on slower devices, where the toolbar appears first (without styles), and then after a microtask delay, Quill is created. Switching to observables resolves this issue because observables can emit both synchronously and asynchronously, and most observables can cache their emissions using `shareReplay`, ensuring that subsequent emissions are always synchronous.
arturovt
force-pushed
the
fix/flickering
branch
from
92ac5e5
to
6345ee6
Compare
|
noice! thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this commit, we introduce a slightly smarter approach to handling custom module registration and executing the
beforeRenderfunction. The current issue is that thequill-editor-toolbarmay be projected before the editor is rendered due to thePromise.allinmergeMap. This is noticeable on slower devices, where the toolbar appears first (without styles), and then after a microtask delay, Quill is created.Switching to observables resolves this issue because observables can emit both synchronously and asynchronously, and most observables can cache their emissions using
shareReplay, ensuring that subsequent emissions are always synchronous.